Skip to content

Conversation

@noodleslove
Copy link
Contributor

Currently if the Component doesn't have session_id attribute it will break. This pull request improve session_id handling by adding fallback mechanisms to retrieve the session ID from different attributes.

Enhance `session_id` handling by adding fallback mechanisms to retrieve the session ID from different attributes, providing more flexibility in component initialization
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Feb 26, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 26, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #6855 will degrade performances by 37.61%

Comparing noodleslove:fix/component/session_id (3458d6c) with main (6017677)

Summary

❌ 2 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 8 ms 12.8 ms -37.61%
test_cancel_nonexistent_build 7.9 ms 10.5 ms -25.49%

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @noodleslove !

This is nice. LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Feb 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 28, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 28, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants