feat: Ollama model name can be selected with a text input node #7282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature will permit to easily change of model when chaining ollama llm nodes
dosubot
bot
added
size:S
github-actions
bot
added
enhancement
sancelot
changed the title
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
ogabrielluiz
requested changes
Apr 8, 2025
There was a problem hiding this comment.
Hey @sancelot
Thanks for the PR.
The correct way of doing this would be to add a input_types = ["Message"] to the model_name input.
|
@ogabrielluiz can't we have a combo box for the drop-down to sort this issue? |
| @@ -34,6 +34,12 @@ class ChatOllamaComponent(LCModelComponent): | |||
| refresh_button=True, | |||
| real_time_refresh=True, | |||
| ), | |||
There was a problem hiding this comment.
Suggested change
| ), | |
| combobox=True | |
| ), |
edwinjosechittilappilly
requested changes
Apr 9, 2025
There was a problem hiding this comment.
Thank you for the PR, can we also try combo box and see if that would fix the issue?
@ogabrielluiz what do you suggest?
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will permit to easily change of model when chaining ollama llm nodes