Skip to content

bug: fix mcp_component _get_tools return always structure tools type #7521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

barnuri
Copy link

@barnuri barnuri commented Apr 9, 2025

This pull request includes a change to the src/backend/base/langflow/components/tools/mcp_component.py file, specifically in the _get_tools method. The change ensures that the method returns a list of tool cache values rather than the tools directly.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Apr 9, 2025
@barnuri barnuri changed the title bug: fix mcp_component _get_tools bug: fix mcp_component _get_tools return always structure tools type Apr 9, 2025
@barnuri barnuri requested a review from ogabrielluiz April 9, 2025 18:38
@edwinjosechittilappilly
Copy link
Collaborator

Ref: #7361

Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you base this PR from the QoL Branch: #7361

Cause this have the updated MCP Component experience and Error Handling.

@barnuri barnuri changed the base branch from main to mcp-sse-tool-mode April 10, 2025 05:13
@barnuri
Copy link
Author

barnuri commented Apr 10, 2025

Can you base this PR from the QoL Branch: #7361

Cause this have the updated MCP Component experience and Error Handling.

done

@edwinjosechittilappilly edwinjosechittilappilly deleted the branch langflow-ai:mcp-sse-tool-mode April 10, 2025 19:45
@barnuri
Copy link
Author

barnuri commented Apr 10, 2025

@edwinjosechittilappilly why you closed it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants