Skip to content

fix: Avoid unnecessary field resets in the API Request component #7544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

thiau
Copy link
Contributor

@thiau thiau commented Apr 9, 2025

This PR fixes some issues related to field reset in the API Request components:

  • Fixes APIRequestComponent reset field when entering the flow #7382 by adding a condition to ensure the use_curl property is active before proceeding with the field reset.
  • Remove the else clause from _update_method_fields to avoid unnecessarily resetting fields to advanced.
  • Update the else clause from _update_curl_mode to only set a field as advanced when use_curl is set.

Test Evidence 1

Before ⬇️

url_reset_smal

After ⬇️

url_reset_fix_small

Test Evidence 2

Before ⬇️

advanced_bug

After ⬇️

advanced_fix

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Apr 9, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIRequestComponent reset field when entering the flow
1 participant