Skip to content

Fix: cleanup normally completed job #7580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

HaloWorld
Copy link

fix #7577

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 11, 2025
@HaloWorld
Copy link
Author

@ogabrielluiz would you please take a look?

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That may cause a job id to not be found when polling for events. We need to make sure we are only cleaning tasks that have been fully consumed or have not worked (which is the case of this conditional)

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 16, 2025
@HaloWorld
Copy link
Author

@ogabrielluiz Thank you for the clarification. I understand that the main concern is that even when task.done() returns True, the queue in event_manager may not be empty, as it could still be used by other components (e.g., for polling events). Therefore, I added a check for queue.empty() before proceeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normally completed job can not be released
2 participants