Skip to content

fix: Allow upload limit increase in kubernetes deployment #7664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Dexter192
Copy link

@Dexter192 Dexter192 commented Apr 16, 2025

For kubernetes deployments, the maximum filesize for e.g. File Components is capped at 1MB due to the Nginx default limit

Since the Nginx service is started via a start-nginx.sh file, adding annotations to the ingress part of the values.yaml does not work
e.g.

ingress:
  enabled: true
  annotations:
    nginx.ingress.kubernetes.io/client-max-body-size: "200M"

or

frontend:
  nginx:
    client_max_body_size: "200M" 

The workaround described in the helm repo also does not work (for me) since the ingress.yaml template sets the service name and port for every path identically:

service:
  name: {{ $fullName }}
    port: 
      number: {{ $svcPort }}

The proposed change would allow the configuration of the client_max_body_size for the nginx configuration while using the existing environment variable LANGFLOW_MAX_FILE_SIZE_UPLOAD. Reusing this variable makes sense as it's purpose is to configure the maximum upload size.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 16, 2025
@github-actions github-actions bot added the bug Something isn't working label Apr 16, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Apr 16, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Apr 16, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Apr 16, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant