fix: Removes embedding model input from GraphRAG component #7709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
@ogabrielluiz @erichare @edwinjosechittilappilly - please review |
erichare
approved these changes
Apr 18, 2025
|
@pedrocassalpacheco i approved it but note there's a ruff styling error, a line being too long it looks like. odd thing is i dont think its from your PR O_O |
|
@erichare - thanks. No, I did not change the file in question. It looks like src/backend/base/langflow/components/embeddings/embedding_model.py is causing styling issues on all open PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Graph RAG component relies on vector store connection injection, meaning it does not need direct access to the embedding model. Whether the embedding is client-side (via a passed model) or server-side (handled transparently), the Graph RAG component remains unaffected. This PR removes the redundant embedding_model input from the Graph RAG component to simplify the interface and reflect this decoupling.