Feature: Adds env var SECRET_KEY_DIR support #7868
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
GarrettGeorge
force-pushed
the
feature/secret-key-dir-env-var
branch
from
e5396c6 to
c0c75c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Langflow's secret key is placed in the same directory as local files such as uploaded files, profile pictures, etc. In order to have these local files shared across instances, many companies like mine, do not want the secret key being saved to the filesystem.
There is some value to saving it to file in case the environment variable
LANGFLOW_SECRET_KEYgets unset or changed. However, it simply doesn't need to be in the same place as the aforementioned local files.This change allows Langflow's deployment to specify
LANGFLOW_SECRET_KEY_DIRto set the file path of thesecret_keyfile.