fix(client): apply timeout to score ingestion - #887
Draft
sidsri14 wants to merge 1 commit into
Draft
Conversation
|
@sidsri14 is attempting to deploy a commit to the langfuse Team on Vercel. A member of the Team first needs to authorize it. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Score ingestion ignored
LANGFUSE_TIMEOUTandLangfuseClient({ timeout })becauseScoreManagerdid not receive the client's resolved timeout. Generated ingestion requests therefore used their 60-second fallback during flush and shutdown.Fixes #883.
Changes
ScoreManager.ScoreManagerconstruction.LANGFUSE_TIMEOUTpath.Verification
pnpm lintpnpm typecheckpnpm test(the repository-wide command includes server-backed E2E)pnpm test:integrationpnpm test:e2e(requires the Docker-based Langfuse server stack; delegated to CI)pnpm format:checkpnpm test:unitpnpm buildRelease info
Bump level
Libraries affected
Changelog notes