Skip to content

Comments

Fix handling of CLICKHOUSE_MIGRATION_URL when clickhouse.host defined#241

Merged
Steffen911 merged 3 commits intolangfuse:mainfrom
jamesmaidment:fix-clickhouse-migration-url
Oct 6, 2025
Merged

Fix handling of CLICKHOUSE_MIGRATION_URL when clickhouse.host defined#241
Steffen911 merged 3 commits intolangfuse:mainfrom
jamesmaidment:fix-clickhouse-migration-url

Conversation

@jamesmaidment
Copy link
Contributor

@jamesmaidment jamesmaidment commented Sep 23, 2025

Fixes #240

When clickhouse.host is defined, the CLICKHOUSE_MIGRATION_URL was being constructed by directly concatenating clickhouse:// with the host value. If the host already contained a protocol (like https://), this resulted in an invalid URL.

Eg:

CLICKHOUSE_MIGRATION_URL: clickhouse://https://<redacted>.us-central1.gcp.clickhouse.cloud:9440
CLICKHOUSE_URL: https://<redacted>.us-central1.gcp.clickhouse.cloud:8443

This uses langfuse.clickhouse.hostname instead of .Values.clickhouse.host in the helper to fix handling of CLICKHOUSE_MIGRATION_URL when clickhouse.host is defined

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2025

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 23, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 6, 2025
@Steffen911 Steffen911 merged commit b6dea8a into langfuse:main Oct 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Custom clickhouse host causes issues with CLICKHOUSE_MIGRATION_URL

3 participants