Fix handling of CLICKHOUSE_MIGRATION_URL when clickhouse.host defined#241
Merged
Steffen911 merged 3 commits intolangfuse:mainfrom Oct 6, 2025
Merged
Conversation
Steffen911
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240
When
clickhouse.hostis defined, theCLICKHOUSE_MIGRATION_URLwas being constructed by directly concatenatingclickhouse://with the host value. If the host already contained a protocol (likehttps://), this resulted in an invalid URL.Eg:
This uses
langfuse.clickhouse.hostnameinstead of.Values.clickhouse.hostin the helper to fix handling ofCLICKHOUSE_MIGRATION_URLwhenclickhouse.hostis defined