Skip to content

Comments

fix: update comments in values.yaml for existing secret usage#242

Merged
Steffen911 merged 3 commits intolangfuse:mainfrom
atobaum:fix/helm-values-comment
Oct 1, 2025
Merged

fix: update comments in values.yaml for existing secret usage#242
Steffen911 merged 3 commits intolangfuse:mainfrom
atobaum:fix/helm-values-comment

Conversation

@atobaum
Copy link
Contributor

@atobaum atobaum commented Sep 24, 2025

Fix comments in the chart values to reflect actural implementation

The comments said postgresql.auth.username and other username values are not used and picked them up from the secrets when existingSecret is set. But the chart uses postgresql.auth.username values regardless the existingSecret value.

{{- if .Values.postgresql.auth.username }}
- name: DATABASE_USERNAME
value: {{ .Values.postgresql.auth.username | quote }}
{{- end }}


Important

Corrects comments in values.yaml to clarify that only passwords, not usernames, are ignored when existingSecret is set for postgresql, clickhouse, and s3.

  • Comments Update:
    • Corrects comments in values.yaml for postgresql.auth, clickhouse.auth, and s3.auth sections.
    • Clarifies that only password is ignored when existingSecret is set, not username.

This description was created by Ellipsis for de52b69. You can customize this summary. It will automatically update as commits are pushed.

@atobaum atobaum requested a review from Steffen911 as a code owner September 24, 2025 06:17
@CLAassistant
Copy link

CLAassistant commented Sep 24, 2025

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 24, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2025
@Steffen911
Copy link
Member

@atobaum Could you update the README file in charts/langfuse as well? This should happen automatically by running docker run --rm --volume "$(pwd):/helm-docs" -u $(id -u) jnorwood/helm-docs:latest.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 30, 2025
@atobaum
Copy link
Contributor Author

atobaum commented Sep 30, 2025

@Steffen911 Updated README.md. PTAL. Thanks for the command!

@Steffen911 Steffen911 merged commit d7a9406 into langfuse:main Oct 1, 2025
3 checks passed
@atobaum atobaum deleted the fix/helm-values-comment branch October 2, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants