fix(clickhouse): honour cluster mode off when using cloud#252
Closed
pjhampton wants to merge 2 commits intolangfuse:mainfrom
Closed
fix(clickhouse): honour cluster mode off when using cloud#252pjhampton wants to merge 2 commits intolangfuse:mainfrom
pjhampton wants to merge 2 commits intolangfuse:mainfrom
Conversation
Member
|
@pjhampton Thank you a lot for raising this. I've implemented another approach via #255 where we evaluate the I agree that the opt-out using the additional env is unintuitive, but I'd like to keep the default behaviour that assumes an external ClickHouse is clustered. With the alternative in place, I'll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you try to use ClickHouse Cloud, you cannot currently set
clickhouse.clusterEnabled: falsebecause of this block. You should be able to set it regardless.{{- if and .Values.clickhouse.deploy ($.Values.clickhouse.replicaCount | int | eq 1) }} - name: CLICKHOUSE_CLUSTER_ENABLED value: "false" {{- end }}The workaround is:
and this PR updates the chart.
IMPORTANT: unit test vibe coded. Please review.
Important
Updates Helm chart to allow disabling ClickHouse cluster mode in cloud environments and adds tests for this behavior.
_helpers.tplto setCLICKHOUSE_CLUSTER_ENABLEDtofalsewhenclickhouse.deployisfalseorclickhouse.replicaCountis 1.CLICKHOUSE_CLUSTER_ENABLEDis not set for multi-replica deployments.clickhouse-cluster_test.yamlto verifyCLICKHOUSE_CLUSTER_ENABLEDisfalsefor external ClickHouse and single replica deployments.CLICKHOUSE_CLUSTER_ENABLEDis not set for multi-replica deployments.This description was created by
for 807e0eb. You can customize this summary. It will automatically update as commits are pushed.