Skip to content

Comments

devops: Adding support for envFrom k8s secrets and configmap#284

Open
akhilrajmailbox wants to merge 3 commits intolangfuse:mainfrom
akhilrajmailbox:feature/envfrom-chart
Open

devops: Adding support for envFrom k8s secrets and configmap#284
akhilrajmailbox wants to merge 3 commits intolangfuse:mainfrom
akhilrajmailbox:feature/envfrom-chart

Conversation

@akhilrajmailbox
Copy link

@akhilrajmailbox akhilrajmailbox commented Nov 27, 2025

This PR adding support for envFrom option for both worker and web deployment and global configuration. This is required when we are using CD tools such as ArgoCD or FluxCD, and where we don't want to hardcode the data in the additionalEnv section of the helm values. This will allow as to use the external secret with all required data without hard coding it in the helm values file in the repo


Important

Adds envFrom support in web and worker deployments to source environment variables from external secrets or configmaps, enhancing flexibility for CD tools.

  • Behavior:
    • Adds envFrom support in web/deployment.yaml and worker/deployment.yaml to source environment variables from external secrets or configmaps.
    • Useful for CD tools like ArgoCD or FluxCD to avoid hardcoding environment variables.
  • Configuration:
    • Introduces additionalEnvFrom in values.yaml for global, web, and worker configurations.
    • Allows specifying secrets or configmaps for environment variables in values.yaml.

This description was created by Ellipsis for baa0624. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 27, 2025
@Steffen911
Copy link
Member

@akhilrajmailbox Do you think you could add a test case that confirms whether they are rendered correctly?

@akhilrajmailbox
Copy link
Author

@Steffen911

I don't have the exact test case now, but the following steps can help to test it with the feature I added in this PR

  • value.yaml file>>
langfuse:
  additionalEnvFrom:
    - secretRef:
        name: langfuse-env-secrets
  • the secret data can be
apiVersion: v1
kind: Secret
metadata:
  name: langfuse-env-secrets
type: Opaque
stringData:
  CLICKHOUSE_DB: "langfuse_prod"
  LANGFUSE_INIT_USER_EMAIL: "admin@example.com"
  LANGFUSE_INIT_USER_PASSWORD: "securedata"

This will add these variable to both worker and web containers. if we need specific container we need to add the additionalEnvFrom in the respective section like how we are passing the additionalEnv params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants