devops: Adding support for envFrom k8s secrets and configmap#284
Open
akhilrajmailbox wants to merge 3 commits intolangfuse:mainfrom
Open
devops: Adding support for envFrom k8s secrets and configmap#284akhilrajmailbox wants to merge 3 commits intolangfuse:mainfrom
akhilrajmailbox wants to merge 3 commits intolangfuse:mainfrom
Conversation
Member
|
@akhilrajmailbox Do you think you could add a test case that confirms whether they are rendered correctly? |
Author
|
I don't have the exact test case now, but the following steps can help to test it with the feature I added in this PR
This will add these variable to both worker and web containers. if we need specific container we need to add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adding support for envFrom option for both worker and web deployment and global configuration. This is required when we are using CD tools such as ArgoCD or FluxCD, and where we don't want to hardcode the data in the
additionalEnvsection of the helm values. This will allow as to use the external secret with all required data without hard coding it in the helm values file in the repoImportant
Adds
envFromsupport in web and worker deployments to source environment variables from external secrets or configmaps, enhancing flexibility for CD tools.envFromsupport inweb/deployment.yamlandworker/deployment.yamlto source environment variables from external secrets or configmaps.additionalEnvFrominvalues.yamlfor global, web, and worker configurations.values.yaml.This description was created by
for baa0624. You can customize this summary. It will automatically update as commits are pushed.