Skip to content

Comments

fix: support passwordless Redis by conditionally building auth segment#292

Merged
Steffen911 merged 1 commit intomainfrom
fix/redis-passwordless-auth
Dec 12, 2025
Merged

fix: support passwordless Redis by conditionally building auth segment#292
Steffen911 merged 1 commit intomainfrom
fix/redis-passwordless-auth

Conversation

@Steffen911
Copy link
Member

@Steffen911 Steffen911 commented Dec 12, 2025

Summary

  • Fixes the REDIS_CONNECTION_STRING to conditionally include the auth segment based on whether redis.auth.password and redis.auth.username are configured
  • When both are set to null, the connection string omits the auth segment entirely (e.g., redis://host:port/db)
  • Allows connections to Redis instances without authentication (e.g., AWS ElastiCache without auth)

Behavior Matrix

redis.auth.password redis.auth.username Connection String
"mypass" "default" redis://default:$(REDIS_PASSWORD)@host:port/db
"mypass" null redis://:$(REDIS_PASSWORD)@host:port/db
null "default" redis://default@host:port/db
null null redis://host:port/db

Test plan

  • Added 4 new test cases for passwordless Redis scenarios
  • All 52 helm unit tests pass
  • Verified connection string output with helm template for each scenario

Fixes #291, fixes #273

🤖 Generated with Claude Code


Important

Supports passwordless Redis by conditionally omitting auth segment in connection string based on configuration.

  • Behavior:
    • Updates REDIS_CONNECTION_STRING in _helpers.tpl to conditionally include auth segment based on redis.auth.password and redis.auth.username.
    • Omits auth segment if both are null, allowing passwordless Redis connections.
    • Supports Redis instances without authentication, such as AWS ElastiCache.
  • Configuration:
    • Updates values.yaml to clarify redis.auth.password and redis.auth.username usage for passwordless connections.
    • Modifies README.md to reflect changes in Redis authentication configuration.
  • Testing:
    • Adds 4 test cases in redis-cluster_test.yaml for passwordless Redis scenarios.
    • Verifies connection string output with helm template for each scenario.

This description was created by Ellipsis for baf48e1. You can customize this summary. It will automatically update as commits are pushed.

When redis.auth.password and redis.auth.username are set to null,
the connection string now omits the auth segment entirely, allowing
connections to Redis instances without authentication (e.g., AWS
ElastiCache without auth enabled).

Behavior:
- password + username: redis://user:$(REDIS_PASSWORD)@host:port/db
- password only (null username): redis://:$(REDIS_PASSWORD)@host:port/db
- username only (null password): redis://user@host:port/db
- neither (both null): redis://host:port/db

Fixes #291, fixes #273

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 12, 2025
@github-actions
Copy link
Contributor

Helm Unit Test Results

52 tests  +4   52 ✅ +4   2s ⏱️ ±0s
 9 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit baf48e1. ± Comparison against base commit cab27df.

@Steffen911 Steffen911 merged commit 7493734 into main Dec 12, 2025
6 checks passed
@Steffen911 Steffen911 deleted the fix/redis-passwordless-auth branch December 12, 2025 14:52
abenfriha-k pushed a commit to Isskar/langfuse-k8s that referenced this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: REDIS_CONNECTION_STRING always contain $(REDIS_PASSWORD} bug: Server not starting with env REDIS_CONNECTION_STRING

1 participant