fix: support passwordless Redis by conditionally building auth segment#292
Merged
Steffen911 merged 1 commit intomainfrom Dec 12, 2025
Merged
fix: support passwordless Redis by conditionally building auth segment#292Steffen911 merged 1 commit intomainfrom
Steffen911 merged 1 commit intomainfrom
Conversation
When redis.auth.password and redis.auth.username are set to null, the connection string now omits the auth segment entirely, allowing connections to Redis instances without authentication (e.g., AWS ElastiCache without auth enabled). Behavior: - password + username: redis://user:$(REDIS_PASSWORD)@host:port/db - password only (null username): redis://:$(REDIS_PASSWORD)@host:port/db - username only (null password): redis://user@host:port/db - neither (both null): redis://host:port/db Fixes #291, fixes #273 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
abenfriha-k
pushed a commit
to Isskar/langfuse-k8s
that referenced
this pull request
Jan 8, 2026
langfuse#292) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REDIS_CONNECTION_STRINGto conditionally include the auth segment based on whetherredis.auth.passwordandredis.auth.usernameare configurednull, the connection string omits the auth segment entirely (e.g.,redis://host:port/db)Behavior Matrix
redis.auth.passwordredis.auth.username"mypass""default"redis://default:$(REDIS_PASSWORD)@host:port/db"mypass"nullredis://:$(REDIS_PASSWORD)@host:port/dbnull"default"redis://default@host:port/dbnullnullredis://host:port/dbTest plan
helm templatefor each scenarioFixes #291, fixes #273
🤖 Generated with Claude Code
Important
Supports passwordless Redis by conditionally omitting auth segment in connection string based on configuration.
REDIS_CONNECTION_STRINGin_helpers.tplto conditionally include auth segment based onredis.auth.passwordandredis.auth.username.null, allowing passwordless Redis connections.values.yamlto clarifyredis.auth.passwordandredis.auth.usernameusage for passwordless connections.README.mdto reflect changes in Redis authentication configuration.redis-cluster_test.yamlfor passwordless Redis scenarios.helm templatefor each scenario.This description was created by
for baf48e1. You can customize this summary. It will automatically update as commits are pushed.