Skip to content

Comments

Fix VPA updateMode YAML parsing by adding quotes#315

Open
DaStru wants to merge 1 commit intolangfuse:mainfrom
DaStru:fix-vpa-quotes
Open

Fix VPA updateMode YAML parsing by adding quotes#315
DaStru wants to merge 1 commit intolangfuse:mainfrom
DaStru:fix-vpa-quotes

Conversation

@DaStru
Copy link

@DaStru DaStru commented Feb 16, 2026

The VPA templates render updateMode without quotes, causing it to be interpreted as a boolean in YAML 1.1. This breaks deployments on clusters with strict VPA webhook validation (like GKE) with the error:

admission webhook "gke-vpa.k8s.io" denied the request: json: cannot unmarshal bool into Go struct field PodUpdatePolicy.spec.updatePolicy.updateMode of type v1.UpdateMode

The issue occurs when users set updateMode: "Off" in values - it gets rendered as unquoted updateMode: Off, which YAML interprets as the boolean false. The VPA API expects a string enum value.

This fix adds the | quote Helm filter to ensure the value is always rendered as a properly quoted string.

Changes:

  • templates/web/vpa.yaml: Quote updateMode value
  • templates/worker/vpa.yaml: Quote updateMode value

Important

Fixes YAML parsing issue by quoting updateMode in VPA templates to prevent boolean misinterpretation.

  • Behavior:
    • Fixes YAML parsing issue by quoting updateMode in web/vpa.yaml and worker/vpa.yaml.
    • Prevents updateMode from being interpreted as a boolean, ensuring it is treated as a string.
  • Files:
    • web/vpa.yaml: Adds | quote to updateMode.
    • worker/vpa.yaml: Adds | quote to updateMode.

This description was created by Ellipsis for 976c746. You can customize this summary. It will automatically update as commits are pushed.

@DaStru DaStru requested a review from Steffen911 as a code owner February 16, 2026 11:56
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 16, 2026
@CLAassistant
Copy link

CLAassistant commented Feb 16, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants