Skip to content

fix http status code #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
binnn6 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix http status code #193

binnn6 wants to merge 1 commit into from

Conversation

@binnn6
Copy link

@binnn6 binnn6 commented Nov 17, 2025

err = r.BindJSON(&request) will write http header to client if err. After this, r.JSON(200, resp) willl cause warning Headers were already written. Wanted to override status code 400 with 200

[GIN-debug] [WARNING] Headers were already written. Wanted to override status code 400 with 200
[GIN] 2025/11/17 - 03:42:24 | 400 | 110.582µs | 172.17.0.1 | POST "/v1/sandbox/run"
[GIN] 2025/11/17 - 03:42:24 | 400 | 133.045µs | 172.17.0.1 | POST "/v1/sandbox/run"

@binnn6
fix http status code
fdac274 
Signed-off-by: binnnliu <[email protected]>
@binnn6
Copy link
Author

binnn6 commented Nov 19, 2025

@Yeuoly Could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@binnn6