Skip to content

fix: implement robust file type checks to align with existing logic #17557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2025

Conversation

lrhan321
Copy link
Contributor

@lrhan321 lrhan321 commented Apr 7, 2025

Summary

Fix the compatibility issue mentioned in #17453 and #16203

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Sorry, something went wrong.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Apr 7, 2025
@crazywoola crazywoola requested a review from laipz8200 April 7, 2025 12:29
@laipz8200
Copy link
Member

Hi @lrhan321, would you mind to add some tests for this PR?

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 14, 2025
@lrhan321
Copy link
Contributor Author

I added some tests, but I'm not sure about the structure and file extension of the tool file. Please check and confirm whether to merge.

@lrhan321
Copy link
Contributor Author

Now, strict validation of file types should only be performed when calling the workflow API and the input contains variables of file types.

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 14, 2025
@crazywoola crazywoola merged commit cac0d3c into langgenius:main Apr 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants