Skip to content

fix: truncate conversation variable description to 255 chars in draft prefill#33393

Open
JasonOA888 wants to merge 2 commits intolanggenius:mainfrom
JasonOA888:fix/truncate-conversation-variable-description
Open

fix: truncate conversation variable description to 255 chars in draft prefill#33393
JasonOA888 wants to merge 2 commits intolanggenius:mainfrom
JasonOA888:fix/truncate-conversation-variable-description

Conversation

@JasonOA888
Copy link

Summary

Fixes #33037 - Prevents StringDataRightTruncation error when conversation variable description exceeds 255 characters.

Problem

When a user sets a conversation variable description longer than 255 characters in the workflow editor, saving succeeds (stored in Workflow._conversation_variables as LongText JSON). However, when the variable inspection panel is opened:

  1. prefill_conversation_variable_default_values copies the description
  2. Into workflow_draft_variables.description (varchar(255))
  3. PostgreSQL raises psycopg2.errors.StringDataRightTruncation

Solution

Truncate description to 255 characters in prefill_conversation_variable_default_values before passing to WorkflowDraftVariable.new_conversation_variable.

# Before
description=conv_var.description,

# After
truncated_description = conv_var.description[:255] if conv_var.description else ""
description=truncated_description,

Changes

File Change
api/services/workflow_draft_variable_service.py Truncate description to 255 chars

Notes

  • This is a backend safeguard
  • Frontend should also add validation (character counter + error toast)
  • No database schema changes required
  • No breaking changes

Testing

  • Verified truncation logic is correct
  • Existing tests should pass (no behavior change for descriptions ≤255 chars)

Closes #33037

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 13, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical backend issue where excessively long conversation variable descriptions could lead to a database error during the prefill process. By introducing a truncation mechanism, the system now gracefully handles descriptions that exceed the database column's character limit, ensuring data integrity and preventing application crashes. This change acts as a backend safeguard, complementing any future frontend validation.

Highlights

  • Database Error Prevention: Implemented a fix to prevent psycopg2.errors.StringDataRightTruncation when a conversation variable description exceeds 255 characters during the prefill process.
  • Description Truncation: Truncated conversation variable descriptions to 255 characters in prefill_conversation_variable_default_values before saving to WorkflowDraftVariable to match the database column constraint.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • api/services/workflow_draft_variable_service.py
    • Truncated conversation variable descriptions to 255 characters to prevent database errors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a StringDataRightTruncation error by truncating conversation variable descriptions to the varchar(255) limit of the workflow_draft_variables.description column. The change correctly truncates the description before creating a WorkflowDraftVariable, which effectively resolves the described bug. The implementation is sound and I have no further feedback.

… prefill

Fixes langgenius#33037 - StringDataRightTruncation error when conversation
variable description exceeds varchar(255)

## Problem
When a user sets a conversation variable description longer than 255
characters in the workflow editor, saving succeeds (stored in
Workflow._conversation_variables as LongText JSON). However, when the
variable inspection panel is opened, prefill_conversation_variable_default_values
copies the description into workflow_draft_variables.description (varchar(255)),
causing a psycopg2.errors.StringDataRightTruncation error.

## Solution
Truncate description to 255 characters in prefill_conversation_variable_default_values
before passing to WorkflowDraftVariable.new_conversation_variable.

This is a backend safeguard. The frontend should also add validation to
prevent descriptions longer than 255 characters with a visible character
counter, but that can be addressed separately.

## Testing
- Manual verification of truncation logic
- No database schema changes required

Closes langgenius#33037
@JasonOA888 JasonOA888 force-pushed the fix/truncate-conversation-variable-description branch from 1735ed8 to 8771555 Compare March 13, 2026 07:02
@github-actions
Copy link
Contributor

Pyrefly Diff

No changes detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

conversation variable description exceeding varchar(255) causes StringDataRightTruncation on draft variable prefill

2 participants