feat(agent): add clarification extensibility hook#33452
feat(agent): add clarification extensibility hook#33452Haohao-end wants to merge 4 commits intolanggenius:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a foundational extensibility hook for future human-in-the-loop (HITL) clarification capabilities within agent nodes. It introduces a new configuration option to enable human clarification, integrates it into the agent node's data schema and UI, and provides a lightweight, placeholder module for the clarification logic. The scope is intentionally minimal to ensure non-breaking changes and ease of integration following recent workflow refactors, setting the stage for more comprehensive HITL features later. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Pyrefly DiffNo changes detected. |
There was a problem hiding this comment.
Code Review
This pull request introduces a foundational extensibility hook for future human-in-the-loop (HITL) clarification support in agent nodes. The changes are well-scoped and non-breaking, adding the necessary configuration options, UI elements, and placeholder logic without implementing the full feature. The new code is accompanied by unit tests. My review includes a couple of suggestions to improve code clarity and test maintainability.
api/tests/unit_tests/core/workflow/nodes/agent/test_clarification_helper.py
Show resolved
Hide resolved
Pyrefly DiffNo changes detected. |
Pyrefly DiffNo changes detected. |
Pyrefly DiffNo changes detected. |
Summary
This PR adds a minimal extensibility hook for future human-in-the-loop clarification support in Agent nodes.
What is included
enable_human_clarificationto agent node data/schemaWhat is intentionally NOT included
Why this scope
The latest workflow refactor changed the internal structure of the agent node, so this PR keeps the scope intentionally small and non-breaking.
This version focuses on configuration infrastructure and extension points only, which makes it easier to review and safer to merge as a first step.
Notes
Test
Intended test target:
python -m pytest api/tests/unit_tests/core/workflow/nodes/agent/test_clarification_helper.py -vIn the current local environment, full test execution is still blocked by missing project dependencies.