fix: auto-detect configured tracing provider when enabling toggle#37241
Open
1795771535y-cell wants to merge 1 commit into
Open
fix: auto-detect configured tracing provider when enabling toggle#372411795771535y-cell wants to merge 1 commit into
1795771535y-cell wants to merge 1 commit into
Conversation
…eventing 'tracing_provider is required' error (langgenius#37174)
dosubot
Bot
added
the
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #37174
When a tracing provider (e.g. Langfuse) has been configured but tracing is disabled, clicking the global enable toggle sends
enabled=truewithouttracing_provider. The backend rejects this with"tracing_provider is required when enabled is True".Root Cause
handleTracingEnabledChangerelied ontracingStatus?.tracing_providerwhich may benulleven when a provider is configured (the tracing config and status are stored via separate APIs).Fix
Added a
configuredProviderhelper that detects the first configured provider from local state. When enabling tracing andtracingStatus.tracing_provideris null, it falls back to the configured provider automatically.Changes
web/app/(commonLayout)/app/(appDetailLayout)/[appId]/overview/tracing/panel.tsx: AddedconfiguredProvidercomputed value from provider config states, used inhandleTracingEnabledChangewhen enabling and no provider is setTesting