refactor: pass db.session explicitly in get_message_data (#37403)#38129
Open
EvanYao826 wants to merge 1 commit into
Open
refactor: pass db.session explicitly in get_message_data (#37403)#38129EvanYao826 wants to merge 1 commit into
EvanYao826 wants to merge 1 commit into
Conversation
dosubot
Bot
added
size:S
Contributor
Pyrefly Type Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make session dependency explicit in
get_message_datautility function, following the pattern from PR #37402.Changes
api/core/ops/utils.pyget_message_data(message_id, session)— replaces internaldb.sessionwith explicit parameterfrom models.engine import dbimport (no longer needed)from sqlalchemy.orm import scoped_sessionimportCallers updated:
api/core/ops/ops_trace_manager.py— passdb.sessiontoget_message_data(5 call sites)Tests updated:
test_utils.py— replace@patch("core.ops.utils.db")with mock session parameterRelated
Closes #37403 (partial)
Checklist