refactor: pass db.session explicitly in sync_account_deletion (#37403)#38130
Open
EvanYao826 wants to merge 2 commits into
Open
refactor: pass db.session explicitly in sync_account_deletion (#37403)#38130EvanYao826 wants to merge 2 commits into
EvanYao826 wants to merge 2 commits into
Conversation
dosubot
Bot
added
size:XS
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-06-29 02:20:24.474712784 +0000
+++ /tmp/pyrefly_pr.txt 2026-06-29 02:20:09.955554626 +0000
@@ -776,6 +776,16 @@
--> tests/test_containers_integration_tests/repositories/test_workflow_run_repository.py:89:56
ERROR `None` is not subscriptable [unsupported-operation]
--> tests/test_containers_integration_tests/services/auth/test_api_key_auth_service.py:196:16
+ERROR Missing argument `session` in function `services.enterprise.account_deletion_sync.sync_account_deletion` [missing-argument]
+ --> tests/test_containers_integration_tests/services/enterprise/test_account_deletion_sync.py:121:43
+ERROR Missing argument `session` in function `services.enterprise.account_deletion_sync.sync_account_deletion` [missing-argument]
+ --> tests/test_containers_integration_tests/services/enterprise/test_account_deletion_sync.py:140:43
+ERROR Missing argument `session` in function `services.enterprise.account_deletion_sync.sync_account_deletion` [missing-argument]
+ --> tests/test_containers_integration_tests/services/enterprise/test_account_deletion_sync.py:154:43
+ERROR Missing argument `session` in function `services.enterprise.account_deletion_sync.sync_account_deletion` [missing-argument]
+ --> tests/test_containers_integration_tests/services/enterprise/test_account_deletion_sync.py:179:43
+ERROR Missing argument `session` in function `services.enterprise.account_deletion_sync.sync_account_deletion` [missing-argument]
+ --> tests/test_containers_integration_tests/services/enterprise/test_account_deletion_sync.py:199:43
ERROR Could not find name `Session` [unknown-name]
--> tests/test_containers_integration_tests/services/plugin/test_plugin_parameter_service.py:54:37
ERROR Could not find name `Session` [unknown-name]
|
Contributor
Pyrefly Type Coverage
|
dosubot
Bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make session dependency explicit in
sync_account_deletionenterprise function, following the pattern from PR #37402.Changes
api/services/enterprise/account_deletion_sync.pysync_account_deletion(account_id, *, source, session)— replaces internaldb.sessionwith explicit parameterfrom extensions.ext_database import dbimport (no longer needed)from sqlalchemy.orm import scoped_sessionimportCallers updated:
api/services/account_service.py— passdb.sessiontosync_account_deletionRelated
Closes #37403 (partial)
Checklist