fix(web): align external API and service API buttons vertically in datasets header#38139
Open
p2003722 wants to merge 1 commit into
Open
fix(web): align external API and service API buttons vertically in datasets header#38139p2003722 wants to merge 1 commit into
p2003722 wants to merge 1 commit into
Conversation
Author
|
Hi @crazywoola @hyoban, just a tiny UI fix for the datasets header buttons' vertical alignment. Could you please take a quick look when you have time? Thanks! |
Member
|
Please attach a screenshot for frontend UI bugs. |
Author
The two components in this area are not aligned vertically. @crazywoola
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does / why we need it
Currently, in the datasets list header, the
External Knowledge APIbutton and theService APIbutton are not perfectly vertically aligned. This is caused by a difference in their DOM structure and flex properties:External Knowledge APIbutton lacks an explicith-6class, making its height dependent on padding and line-height.Service APIbutton is wrapped in a block-level<div>which interferes with theitems-centerflex alignment of the parent container.This PR fixes the vertical alignment by:
h-6to theExternal Knowledge APIbutton to ensure a strict 24px height.Service APIouter wrapper to<div className="flex items-center">.Which issue(s) this PR fixes
N/A