refactor(web): replace lamejs mp3 encoding#38173
Draft
hyoban wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38173 +/- ##
==========================================
+ Coverage 85.32% 85.38% +0.05%
==========================================
Files 4967 5122 +155
Lines 258518 262867 +4349
Branches 49059 50117 +1058
==========================================
+ Hits 220593 224442 +3849
- Misses 33632 34132 +500
Partials 4293 4293
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fixes #38172
lamejsvoice input MP3 encoding with Mediabunny and@mediabunny/mp3-encoder.AudioSampleSourceandMp3OutputFormatwhile preserving theaudio/mp3upload behavior.lamejstype declarations and update voice input tests for mono, stereo, native encoder detection, and invalid channel data.Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsValidation
pnpm -C web test app/components/base/voice-input/__tests__/utils.spec.tspnpm -C web test app/components/base/voice-input/__tests__/index.spec.tsxpnpm -C web type-checkpnpm -C web lint:tsspnpm -C web exec tsx -e "..."smoke test for real Mediabunny MP3 encoding:audio/mp3 3060pnpm -C web exec vp stagedwas attempted, but this repository currently reports:No "staged" config found in vite.config.ts.From Codex