Allow relaxation of ReLUQuadratic #178
Conversation
Robbybp
changed the title
| @@ -244,7 +244,7 @@ function add_predictor( | |||
| end | |||
|
|
|||
| """ | |||
| ReLUQuadratic() <: AbstractPredictor | |||
| ReLUQuadratic(; relaxation_parameter = nothing) <: AbstractPredictor | |||
There was a problem hiding this comment.
I'm okay with the name, but other options could be: relaxation_tolerance, tolerance, atol, complementarity_mu, mu, complementarity_tolerance... not sure if any of those are better
There was a problem hiding this comment.
I like relaxation_* as it communicates the qualitative change that happens when this parameter is set. (Although I may kick myself for this when I inevitably forget what this is called in six months.) I could go with tolerance or parameter.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 639 644 +5
=========================================
+ Hits 639 644 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #177. I didn't put much thought into the names. This still needs to update the docstring.