Fargo - #127
Conversation
… remaps in the X2 and X3 directions rather than try to reuse one routine but pass k-slices or j-slices.
|
@pdmullen tests now pass (I fixed one issue), so I think this is ready for real review. |
| using ArtemisUtils::PLM; | ||
| using ArtemisUtils::VI; | ||
|
|
||
| #define CUB(x) ((x) * (x) * (x)) |
| if (j >= js && j <= je) v0(b, n, k, j, i) += dq / r.vol; | ||
| if (jp >= js && jp <= je) v0(b, n, k, jp, i) -= dq / rp.vol; |
There was a problem hiding this comment.
Can you help me understand the conditionals here?
There was a problem hiding this comment.
It's just checking that we only update the active cells
| if (k >= ks && k <= ke) v0(b, n, k, j, i) += dq / r.vol; | ||
| if (kp >= ks && kp <= ke) v0(b, n, kp, j, i) -= dq / rp.vol; |
| oa.ApplyGradSkew(rd); | ||
| } | ||
| RemapUpdate(v0, ru, rc, vb, dwdt, three_d, b, n, k, j, j + joff, i); | ||
| RemapUpdateX2<GEOM>(oa, v0, ru, rc, vb, three_d, b, n, k, j, j + joff, i, jb.s, |
There was a problem hiding this comment.
Also need some help here. Are we still doing a sweep as we had done it before. It looks like it, but more indexing enters the RemapUpdate function call.
|
I'm fairly happy with what I'm seeing in shearing box, 2D (r,phi), and 3D spherical tests with a binary. So I think this is more or less ready to merge. Want to give it another look @pdmullen ? Or merge and fix issues later? |
LGTM. Merge. |
Can i get an approval? |
2 participants
Background
This extends our linear advection machinery to work in spherical and cylindrical coordinates where the background velocity is assumed to be keplerian.
To keep the overlap integrals analytic, we make the approximation that in cylindrical/axisymmetric coordinates the radius in the keplerian Omega is the cylindrical R but in spherical is the spherical r.
This was done with the help of GPT (I still need to put the AI statement in the files).
This more or less works, but it's not quite ready yet.
Description of Changes
Checklist
// This file was created in part or in whole by generative AI