Skip to content

count number of lines pythonically, remove dep on wc and subprocess #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

count number of lines pythonically, remove dep on wc and subprocess #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions db_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,11 @@
import sys
import os
import time
import subprocess


def parse(input_filename, output_filename):
"Feed it a file, and it'll output a fixed one"

# State storage
if input_filename == "-":
num_lines = -1
else:
num_lines = int(subprocess.check_output(["wc", "-l", input_filename]).strip().split()[0])
tables = {}
current_table = None
creation_lines = []
Expand All @@ -43,10 +37,14 @@ def parse(input_filename, output_filename):
output = open(output_filename, "w")
logging = sys.stdout

# Open the input file and state storage
if input_filename == "-":
input_fh = sys.stdin
num_lines = -1
else:
input_fh = open(input_filename)
num_lines = sum(1 for l in input_fh)
input_fh.seek(0)


output.write("-- Converted by db_converter\n")
Expand Down