Skip to content

Fix type casting of DOUBLE. Remove 'COMMENT' statement from field definition. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix type casting of DOUBLE. Remove 'COMMENT' statement from field definition. #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6552050
Fix type casting of DOUBLE.
vkuzmov Oct 9, 2016
1762f14
Remove 'COMMENT' statement from field definition.
vkuzmov Oct 9, 2016
7212788
Handle MySQL's YEAR type.
vkuzmov May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion db_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ def parse(input_filename, output_filename):
extra = ""
extra = re.sub("CHARACTER SET [\w\d]+\s*", "", extra.replace("unsigned", ""))
extra = re.sub("COLLATE [\w\d]+\s*", "", extra.replace("unsigned", ""))
extra = re.sub("COMMENT ('|\").*('|\")", "", extra.replace("", ""))

# See if it needs type conversion
final_type = None
Expand All @@ -132,9 +133,12 @@ def parse(input_filename, output_filename):
elif type.startswith("smallint("):
type = "int2"
set_sequence = True
elif type.startswith("year("):
type = "int2"
set_sequence = True
elif type == "datetime":
type = "timestamp with time zone"
elif type == "double":
elif type.startswith("double("):
type = "double precision"
elif type.endswith("blob"):
type = "bytea"
Expand Down