-
Notifications
You must be signed in to change notification settings - Fork 157
Fix text-input Chinese input #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
QQ2025430-231030-HD.mp4 |
We probably should call https://github.com/lapce/floem/blob/main/src/action.rs#L213 And call |
Ok, I will try to solve it tomorrow. |
The calling of |
id.update_state((text, is_focused.get())); | ||
let is_focused = is_focused.get(); | ||
id.update_state((text, is_focused)); | ||
set_ime_allowed(is_focused); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be issue when the focus is switched from one text input to another, and we can't guarantee the execution order of the set_ime_allowed
, so when the loosing focus text input execute this later than the gaining focus one, the ime would be disallowed. We need a central state of whether ime should be allowed.
Now IME is allowed for the window winit created, and the text input can handle the ImeCommit event,
BUT the render issue when there is CJK text in the text-input still exists.