Skip to content

Version 2.0.x support of Laravel Doctrine ORM ^3.1 and Laravel 12#73

Merged
TomHAnderson merged 9 commits intolaravel-doctrine:2.0.xfrom
ScholarshipOwl:2.0.x
Apr 30, 2025
Merged

Version 2.0.x support of Laravel Doctrine ORM ^3.1 and Laravel 12#73
TomHAnderson merged 9 commits intolaravel-doctrine:2.0.xfrom
ScholarshipOwl:2.0.x

Conversation

@R3VoLuT1OneR
Copy link
Contributor

@R3VoLuT1OneR R3VoLuT1OneR commented Apr 26, 2025

  • Support of Laravel 12
  • Support of Laravel Doctrine ORM ^3.1
  • Migrated to attributes instead of annotations
  • PHPUnit setup workbench for laravel imulation
  • GitHub actions setup php tests on github
  • PHPCS, PHPStan upgrade coding standards
  • Updated README.md

@R3VoLuT1OneR
Version 2.0.x support of Laravel Doctrine ORM ^3.1 and Laravel 12
b96a3e8 
- Support of Laravel 12
- Support of Laravel Doctrine ORM ^3.1
- Migrated to attributes instead of annotations
- PHPUnit setup workbench for laravel imulation
- GitHub actions setup php tests on github
- PHPCS, PHPStan upgrade coding standards
- Updated README.md
@codecov
Copy link

codecov bot commented Apr 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.82353% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (2.0.x@8eafde6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Mappings/Builders/ManyToManyBuilder.php 87.50% 1 Missing ⚠️
src/Mappings/Builders/ManyToOneBuilder.php 83.33% 1 Missing ⚠️
src/Permissions/WithPermissions.php 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             2.0.x      #73   +/-   ##
========================================
  Coverage         ?   98.73%           
  Complexity       ?      138           
========================================
  Files            ?       23           
  Lines            ?      316           
  Branches         ?        0           
========================================
  Hits             ?      312           
  Misses           ?        4           
  Partials         ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@R3VoLuT1OneR R3VoLuT1OneR mentioned this pull request Apr 26, 2025
Closed
TomHAnderson
TomHAnderson requested changes Apr 26, 2025
View reviewed changes
@R3VoLuT1OneR
Copy link
Contributor Author

R3VoLuT1OneR commented Apr 27, 2025

@TomHAnderson
Thanks you for the review, shame on me not using PHPCS by default.

I resolved all the conversations I fixed and considered small or should I keep them open so you will resolve them?

@TomHAnderson
Copy link
Contributor

TomHAnderson commented Apr 27, 2025

I'll go through and resolve them. I'm out today but will look at this again tonight.

TomHAnderson
TomHAnderson reviewed Apr 27, 2025
View reviewed changes
Copy link
Contributor

@TomHAnderson TomHAnderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work on this. Looking for your feedback on these final two notes.

@R3VoLuT1OneR R3VoLuT1OneR force-pushed the 2.0.x branch 2 times, most recently from 1e5581c to 6ee3ab6 Compare April 28, 2025 09:21
@TomHAnderson
Copy link
Contributor

TomHAnderson commented Apr 30, 2025

I'm ready to approve this. Are you ready for a 2.0.0 release when I do?

@R3VoLuT1OneR
Copy link
Contributor Author

R3VoLuT1OneR commented Apr 30, 2025

I'm ready to approve this. Are you ready for a 2.0.0 release when I do?

Great, I think we can release it yes.

@TomHAnderson TomHAnderson merged commit bbf7cb9 into laravel-doctrine:2.0.x Apr 30, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomHAnderson TomHAnderson Awaiting requested review from TomHAnderson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@R3VoLuT1OneR @TomHAnderson