Use major.minor PHP version in guidelines instead of full version#657
Merged
pushpak1300 merged 1 commit intolaravel:mainfrom Mar 12, 2026
Merged
Conversation
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the PHP version output in generated guidelines and the
ApplicationInfoMCP tool to use only the major and minor version (e.g.8.4) instead of the full version including the patch number (e.g.8.4.3).Motivation
On teams where different members may be running slightly different patch versions of PHP (e.g.
8.4.1vs8.4.3), the fullPHP_VERSIONconstant causes unnecessary churn in guideline files. Every time a team member with a different patch version runs the install command, the guideline file changes, leading to noisy diffs and constant re-generation. Since the patch version is rarely relevant to coding guidelines or API compatibility, using only the major and minor version keeps guideline files stable across the team.Changes
.ai/foundation.blade.php— Changed{{ PHP_VERSION }}to{{ PHP_MAJOR_VERSION }}.{{ PHP_MINOR_VERSION }}src/Mcp/Tools/ApplicationInfo.php— ChangedPHP_VERSIONtoPHP_MAJOR_VERSION.'.'.PHP_MINOR_VERSIONtests/Feature/Mcp/Tools/ApplicationInfoTest.php— Updated test assertions to match the new formatImpact
8.x.xto8.x, which is still valid and more appropriate for guidelines$package->majorVersion())