Move mergeConfigFrom from register to boot method #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why in register?
Move mergeConfigFrom from register to boot method
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why configs should be in register(), not in boot()? As I know from docs: register() is used only to bind things and You should never attempt to register any event listeners, routes, or any other piece of functionality within the register method [ref]. It caused small error in our platform. We expand our core, from vendor, and in core we have a config merging logic in boot() like: client -> core -> fortify. For example Spatie packages, loads in boot and their solution works good with our logic. Just wondering why fortify did it in register()?
Spatie packages example
!!!! Important. I did not double-check the fortify functionality of this MR, just relying to written tests. Just curious why in register()