Added dedicated Request object to PasswordResetLinkController #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a dedicated request object to the PasswordResetLinkController. The purpose of this change is to allow extensibility of the PasswordResetLinkRequest so that additional validation can be implemented.
Reason: The reason I'd like to implement this is to add validation for reCAPTCHA to protect the forms for example. Using this I can extend the validation for the password reset link to ensure that a valid reCAPTCHA payload is also supplied.
Non breaking: This is a non-breaking change and by default implements the same validation rules.
Thanks,
Chris.