Repository navigation
Error: comma in translation key in email template #54735
Description
I have noticed that the email template contains a comma in the translation key for the salutation “Regards”. This is problematic because punctuation marks such as commas should not be part of the translation key, as they are language-specific and not part of the translatable text.
Activity
cwang22 commentedon Feb 21, 2025
some languages use a different set of punctuation. for example in Chinese/Japanese/Korean comma is
， (U+FF0C)instead of, (U+002C). So including the comma in the translatable text does make sense.rodrigopedra commentedon Feb 21, 2025
The comma is just on the key, you can use whatever punctuation in the translated text. The key could be anything, a constant in all caps, for example.
The key is a phrase in English, so it defaults to it when translating files are missing. But including the trailing comma makes no difference.
As @cwang22 said, that allows to use different punctuation symbols when translating to languages which use different symbols.
Or even none at all. I usually don't have a trailing comma for this translation in Portuguese, as it is optional by some style guides in Portuguese on these kinds of ending statements before a sender's name.
On another project for a client, they asked to use the company's motto ended by an exclamation mark.
IMO, no punctuation should be hard-coded in a way it couldn't be replaced by translation. As it is right now.