Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Remove redundant variable declarations #54245

Closed
wants to merge 1 commit into from

Conversation

zds-s
Copy link
Contributor

@zds-s zds-s commented Jan 18, 2025

Hello, I noticed that there is a sync variable declared but not used in the getOriginal method of HasAttributes. Perhaps it should be considered to be removed.

@zds-s zds-s changed the title chore: Remove redundant variable declarations [11.x] Remove redundant variable declarations Jan 18, 2025
@antonkomarev
Copy link
Contributor

antonkomarev commented Jan 18, 2025

I suppose it's added to make meaning of true more clear. Can be replaced with a named attribute now.

@milwad-dev
Copy link
Contributor

It's just for more readable

@zds-s zds-s closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants