[11.x] check not empty before concat url

[MrTuffaha]

When using packages that adds a default prefix in filesystem config (example steffjenl/laravel-azure-blob-storage).

The FilesystemAdapter adds a "/" before the path as it only checks if prefix is set not also if its not empty, this may result in a url with double slashes "//".

this pull checks if prefix is not empty before combining it with path

[rodrigopedra]

Likely a breaking change:

<?php

function originalImplementation($url, $path)
{
    return rtrim($url, '/') . '/' . ltrim($path, '/');
}

function proposedImplementation($url, $path)
{
    if (empty($url)) {
        return trim($path, '/');
    }

    if (empty($path)) {
        return trim($url, '/');
    }

    return rtrim($url, '/') . '/' . ltrim($path, '/');
}

$urls = ['', 'https://url.with.slash/', 'https://url.without.slash'];
$paths = ['', '/', 'path', 'path/', '/path', '/path/'];

foreach ($urls as $url) {
    foreach ($paths as $path) {
        echo originalImplementation($url, $path), PHP_EOL;
    }

}

echo str_repeat('-', 80), PHP_EOL;

foreach ($urls as $url) {
    foreach ($paths as $path) {
        echo proposedImplementation($url, $path), PHP_EOL;
    }
}

Output:

$ php test.php 
/
/
/path
/path/
/path
/path/
https://url.with.slash/
https://url.with.slash/
https://url.with.slash/path
https://url.with.slash/path/
https://url.with.slash/path
https://url.with.slash/path/
https://url.without.slash/
https://url.without.slash/
https://url.without.slash/path
https://url.without.slash/path/
https://url.without.slash/path
https://url.without.slash/path/
--------------------------------------------------------------------------------


path
path
path
path
https://url.with.slash
https://url.with.slash/
https://url.with.slash/path
https://url.with.slash/path/
https://url.with.slash/path
https://url.with.slash/path/
https://url.without.slash
https://url.without.slash/
https://url.without.slash/path
https://url.without.slash/path/
https://url.without.slash/path
https://url.without.slash/path/