fix(cache/redis): use connectionAwareSerialize in RedisStore::putMany() #55814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache RedisStore::putMany() should not serialize values if the connection already uses serialization.
This prevents a bug with the following setup:
"serializer" => Redis::SERIALIZER_IGBINARY
When using
Cache::flexible()
, the value returned is correct only the first time. Subsequent calls return a PHP serialized value:This is caused by
RedisStore::putMany()
method, which - contrarily to other methods in this class - doesn't useRedisStore::connectionAwareSerialize
.In the meantime,
RedisStore::many()
method usesRedisStore::connectionAwareUnserialize()
, so it doesn't unserialize the value that is returned.This PR fixes this inconsistent behavior by changing
RedisStore::putMany()
so it usesRedisStore::connectionAwareSerialize
.The result is what one should expect: