-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[12.x] Render newlines in query tooltip #57310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
faisuc
wants to merge
9
commits into
laravel:12.x
Choose a base branch
from
faisuc:fix/exceptions-renderer-tooltip-newlines-escape
base: 12.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[12.x] Render newlines in query tooltip #57310
faisuc
wants to merge
9
commits into
laravel:12.x
from
faisuc:fix/exceptions-renderer-tooltip-newlines-escape
+78
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
reviewed
Oct 8, 2025
crynobone
reviewed
Oct 9, 2025
src/Illuminate/Foundation/resources/exceptions/renderer/components/request-header.blade.php
Outdated
Show resolved
Hide resolved
…ents/request-header.blade.php
Fixed failling tests |
avosalmon
reviewed
Oct 9, 2025
src/Illuminate/Foundation/resources/exceptions/renderer/components/formatted-source.blade.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Foundation/resources/exceptions/renderer/components/query.blade.php
Outdated
Show resolved
Hide resolved
avosalmon
reviewed
Oct 10, 2025
src/Illuminate/Foundation/resources/exceptions/renderer/components/request-header.blade.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes frontend breakage on the exception renderer by escaping tooltip content and converting newlines to
<br>
. It applies to queries, formatted source, request headers, and routing values, preventing layout overlap and syntax highlighter glitches when tooltip content contains newlines. Fixes #57246.No breaking changes. This affects only the debug exception renderer UI and does not change any APIs.