Skip to content

Adding tests ensuring action() returns first route for overlapping routes #57347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: 12.x
Choose a base branch
from
+69 −0
Draft

Adding tests ensuring action() returns first route for overlapping routes #57347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d617622
Adding tests ensuring action() returns first route
mathiasgrimm Oct 10, 2025
fcc925c
Apply fixes from StyleCI
StyleCIBot Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions tests/Integration/Routing/CompiledRouteCollectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,39 @@ public function testRouteWithSamePathAndSameMethodButDiffDomainNameWithOptionsMe
], $this->collection()->getRoutesByMethod());
}

public function testActionUrlGenerationChoosesFirstMatchingRouteWithCompiledRoutes()
{
$this->routeCollection->add($this->newRoute('GET', '{resource}/attachable/{field}', [
'controller' => 'MyController',
]));

$this->routeCollection->add($this->newRoute('GET', '{resource}/{resourceId}/attachable/{field}', [
'controller' => 'MyController',
]));

$routes = $this->collection();

$url = app('url');
$url->setRoutes($routes);

$result = $url->action('MyController', [
'resource' => 'posts',
'resourceId' => 1,
'field' => 'category',
'foo' => 'bar',
]);

$this->assertStringEndsWith('/posts/attachable/category?resourceId=1&foo=bar', $result);

$result = $url->action('MyController', [
'resource' => 'posts',
'field' => 'category',
'foo' => 'bar',
]);

$this->assertStringEndsWith('/posts/attachable/category?foo=bar', $result);
}

/**
* Create a new Route object.
*
Expand Down
36 changes: 36 additions & 0 deletions tests/Routing/RoutingUrlGeneratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2000,6 +2000,42 @@ public function testUrlGenerationWithOptionalParameters(): void
$url->route('tenantPostUserOptionalMethod', ['concreteTenant', 'concretePost', 'concreteUser', 'concreteMethod']),
);
}

public function testActionUrlGenerationChoosesFirstMatchingRoute()
{
$routes = new RouteCollection;
$request = Request::create('http://www.foo.com/');
$url = new UrlGenerator($routes, $request);

$route1 = new Route(['GET'], '{resource}/attachable/{field}', [
'controller' => 'MyController',
]);
$routes->add($route1);

$route2 = new Route(['GET'], '{resource}/{resourceId}/attachable/{field}', [
'controller' => 'MyController',
]);
$routes->add($route2);

$routes->refreshActionLookups();

$result = $url->action('MyController', [
'resource' => 'posts',
'resourceId' => 1,
'field' => 'category',
'foo' => 'bar',
]);

$this->assertSame('http://www.foo.com/posts/attachable/category?resourceId=1&foo=bar', $result);

$result = $url->action('MyController', [
'resource' => 'posts',
'field' => 'category',
'foo' => 'bar',
]);

$this->assertSame('http://www.foo.com/posts/attachable/category?foo=bar', $result);
}
}

class RoutableInterfaceStub implements UrlRoutable
Expand Down