Skip to content

Update Command::withProgressBar phpdoc to account for arrow functions and non-void return types #58766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 6 commits into from
Mar 14, 2026
Merged

Update Command::withProgressBar phpdoc to account for arrow functions and non-void return types #58766

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c6f9ad
Allow `mixed` return type on `withProgressBar` $callback param
billypoke Feb 11, 2026
57718de
wrap return type
billypoke Feb 11, 2026
0aed2f5
workaround for phpstan union types
billypoke Feb 12, 2026
9cf712d
Add new template types for callback return and overall function return
billypoke Feb 12, 2026
bc665ca
Merge branch 'laravel:12.x' into patch-1
billypoke Mar 14, 2026
060aeb3
return mixed instead of extra template type
billypoke Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Console/Concerns/InteractsWithIO.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ public function table($headers, $rows, $tableStyle = 'default', array $columnSty
* @template TValue
*
* @param iterable<TKey, TValue>|int $totalSteps
* @param \Closure(\Symfony\Component\Console\Helper\ProgressBar|TValue, \Symfony\Component\Console\Helper\ProgressBar|null, TKey|null): void $callback
* @param \Closure(\Symfony\Component\Console\Helper\ProgressBar): (mixed|void)|\Closure(TValue, \Symfony\Component\Console\Helper\ProgressBar, TKey): (mixed|void) $callback
* @return mixed|void
*/
public function withProgressBar($totalSteps, Closure $callback)
Expand Down