[12.x] Add dispatchBatchInChain() to Queueable trait#58916
Open
heffaklump90 wants to merge 2 commits intolaravel:12.xfrom
Open
[12.x] Add dispatchBatchInChain() to Queueable trait#58916heffaklump90 wants to merge 2 commits intolaravel:12.xfrom
heffaklump90 wants to merge 2 commits intolaravel:12.xfrom
Conversation
Move batch-in-chain dispatch logic from ChainedBatch into the Queueable trait so any job (including closure jobs) can hand off chain continuation to a batch at runtime. ChainedBatch now delegates to this method instead of having its own copy of the logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dispatchBatchInChain(PendingBatch $batch)method to theQueueabletrait, allowing any job (including closure jobs) to dispatch a batch as part of the current job chainChainedBatchto delegate to this new method instead of duplicating the logicChainedBatch::attachRemainderOfChainToEndOfBatch()(now handled by the trait method)Motivation
As suggested by @dxnter in PR #58905, this approach is simpler than a dedicated
DeferredBatchclass. Any job can now call$this->dispatchBatchInChain($batch)to hand off chain continuation to a batch at runtime — no new class needed.Test plan
BusDispatchBatchInChainTestcovering: batch dispatch with chain clearing, cancelled batch handling, catch callback propagation, empty chain, chain metadata propagation, andCallQueuedClosurecompatibilityBusBatchTestpasses unchanged (behavior is identical)🤖 Generated with Claude Code