Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/Illuminate/Console/Scheduling/PendingEventAttributes.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ class PendingEventAttributes
{
use ManagesAttributes, ManagesFrequencies;

/**
* The recorded macro calls to replay on each event.
*
* @var array<int, array{string, array}>
*/
protected array $macros = [];

/**
* Create a new pending event attributes instance.
*/
Expand Down Expand Up @@ -81,13 +88,23 @@ public function mergeAttributes(Event $event): void
foreach ($this->rejects as $reject) {
$event->skip($reject);
}

foreach ($this->macros as [$method, $parameters]) {
$event->{$method}(...$parameters);
}
}

/**
* Proxy missing methods onto the underlying schedule.
*/
public function __call(string $method, array $parameters): mixed
{
if (Event::hasMacro($method)) {
$this->macros[] = [$method, $parameters];

return $this;
}

return $this->schedule->{$method}(...$parameters);
}
}
2 changes: 1 addition & 1 deletion src/Illuminate/Console/Scheduling/Schedule.php
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ public function __call($method, $parameters)
return $this->macroCall($method, $parameters);
}

if (method_exists(PendingEventAttributes::class, $method)) {
if (method_exists(PendingEventAttributes::class, $method) || Event::hasMacro($method)) {
$this->attributes ??= $this->groupStack ? clone array_last($this->groupStack) : new PendingEventAttributes($this);

return $this->attributes->$method(...$parameters);
Expand Down
99 changes: 99 additions & 0 deletions tests/Integration/Console/Scheduling/ScheduleGroupTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Illuminate\Tests\Integration\Console\Scheduling;

use Illuminate\Console\Scheduling\Event;
use Illuminate\Console\Scheduling\Schedule as ScheduleClass;
use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Schedule;
Expand Down Expand Up @@ -213,4 +214,102 @@ public function testGroupedPendingEventAttributesWithoutOverlapping()
$this->assertSame('* * * * 1-5', $events[2]->expression);
$this->assertSame('0 4 * * 1-5', $events[3]->expression);
}

public function testGroupAppliesEventMacrosToAllEvents()
{
Event::macro('sentryMonitor', function () {
$this->sentryMonitored = true;

return $this;
});

$schedule = new ScheduleClass;
$schedule->daily()->sentryMonitor()->group(function ($schedule) {
$schedule->command('inspire');
$schedule->command('inspire');
});

$events = $schedule->events();
$this->assertTrue($events[0]->sentryMonitored);
$this->assertTrue($events[1]->sentryMonitored);
$this->assertSame('0 0 * * *', $events[0]->expression);
$this->assertSame('0 0 * * *', $events[1]->expression);

Event::flushMacros();
}

public function testGroupAppliesEventMacroCalledBeforeBuiltInAttributes()
{
Event::macro('sentryMonitor', function () {
$this->sentryMonitored = true;

return $this;
});

$schedule = new ScheduleClass;
$schedule->sentryMonitor()->daily()->onOneServer()->group(function ($schedule) {
$schedule->command('inspire');
});

$events = $schedule->events();
$this->assertTrue($events[0]->sentryMonitored);
$this->assertTrue($events[0]->onOneServer);
$this->assertSame('0 0 * * *', $events[0]->expression);

Event::flushMacros();
}

public function testGroupAppliesMultipleEventMacros()
{
Event::macro('sentryMonitor', function () {
$this->sentryMonitored = true;

return $this;
});

Event::macro('customTag', function ($tag) {
$this->customTag = $tag;

return $this;
});

$schedule = new ScheduleClass;
$schedule->daily()->sentryMonitor()->customTag('billing')->group(function ($schedule) {
$schedule->command('inspire');
$schedule->command('inspire');
});

$events = $schedule->events();
$this->assertTrue($events[0]->sentryMonitored);
$this->assertSame('billing', $events[0]->customTag);
$this->assertTrue($events[1]->sentryMonitored);
$this->assertSame('billing', $events[1]->customTag);

Event::flushMacros();
}

public function testNestedGroupInheritsEventMacros()
{
Event::macro('sentryMonitor', function () {
$this->sentryMonitored = true;

return $this;
});

$schedule = new ScheduleClass;
$schedule->daily()->sentryMonitor()->group(function ($schedule) {
$schedule->command('inspire');
$schedule->weekly()->group(function ($schedule) {
$schedule->command('inspire');
});
});

$events = $schedule->events();
$this->assertTrue($events[0]->sentryMonitored);
$this->assertSame('0 0 * * *', $events[0]->expression);
$this->assertTrue($events[1]->sentryMonitored);
$this->assertSame('0 0 * * 0', $events[1]->expression);

Event::flushMacros();
}
}
Loading