Wrap the closure return type in withFreshQueryLog() - #61444
Open
SanderMuller wants to merge 1 commit into
Open
Conversation
SanderMuller
force-pushed
the
closure-return-type-parens
branch
from
September 5, 2026 23:55
39ac2e8 to
906167c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withFreshQueryLog()is annotated:No phpdoc standard settles whether that trailing
[]belongs to the return type or to the whole closure. PHPStan binds it to the return type, so$callbackis a closure returning a list of log entries. Mago, another static analyser, binds it to the closure and reads$callbackas an array of closures. That contradicts the method's own@return array{...}[]and the body doing$result = $callback().Wrapping the return type in parentheses says which one was meant, and both analysers then agree. PHPStan's inference does not change. I ran both forms and each gives:
Mago's maintainer suggested this form for the same reason, since neither analyser can change its precedence without breaking its own users: carthage-software/mago#2310
This is the only annotation of this shape in the framework.