[13.x] Push batched jobs to their own queue when the batch has no queue - #61450
Open
xurshudyan wants to merge 2 commits into
Open
[13.x] Push batched jobs to their own queue when the batch has no queue#61450xurshudyan wants to merge 2 commits into
xurshudyan wants to merge 2 commits into
Conversation
Contributor
|
Seems odd to me to do this within a batch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a batch is dispatched without
onQueue(), every job goes to the default queue even if the job itself set a queue:With this change the job goes to
images.Bus::batch()->onQueue()still applies to every job as before, so existing batches are not affected.