Skip to content

Fix firebase/php jwt vuln #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 2 commits into from
Feb 19, 2026
+21 −21
Merged

Fix firebase/php jwt vuln #1889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e72cd4d
Composer and first test fixes port from 13.x
Feb 19, 2026
ddd5727
Last test file fixes porting
Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"require": {
"php": "^8.0",
"ext-json": "*",
"firebase/php-jwt": "^6.4",
"firebase/php-jwt": "^6.4|^7.0",
"illuminate/auth": "^9.21|^10.0|^11.0|^12.0",
"illuminate/console": "^9.21|^10.0|^11.0|^12.0",
"illuminate/container": "^9.21|^10.0|^11.0|^12.0",
Expand Down
4 changes: 2 additions & 2 deletions tests/Unit/ApiTokenCookieFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function test_cookie_can_be_successfully_created()
'secure' => true,
'same_site' => 'lax',
]);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter(str_repeat('a', 32), 'aes-256-cbc');
$factory = new ApiTokenCookieFactory($config, $encrypter);

$cookie = $factory->make(1, 'token');
Expand All @@ -50,7 +50,7 @@ public function test_cookie_can_be_successfully_created_when_using_a_custom_encr
'secure' => true,
'same_site' => 'lax',
]);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter(str_repeat('a', 32), 'aes-256-cbc');
$factory = new ApiTokenCookieFactory($config, $encrypter);

$cookie = $factory->make(1, 'token');
Expand Down
36 changes: 18 additions & 18 deletions tests/Unit/TokenGuardTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public function test_users_may_be_retrieved_from_cookies_with_csrf_token_header(
$userProvider = m::mock(PassportUserProvider::class);
$tokens = m::mock(TokenRepository::class);
$clients = m::mock(ClientRepository::class);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter($key = str_repeat('a', 32), 'aes-256-cbc');

$clients->shouldReceive('findActive')
->with(1)
Expand All @@ -166,7 +166,7 @@ public function test_users_may_be_retrieved_from_cookies_with_csrf_token_header(
'aud' => 1,
'csrf' => 'token',
'expiry' => Carbon::now()->addMinutes(10)->getTimestamp(),
], str_repeat('a', 16), 'HS256'), false)
], $key, 'HS256'), false)
);

$guard = new TokenGuard($resourceServer, $userProvider, $tokens, $clients, $encrypter, $request);
Expand All @@ -185,7 +185,7 @@ public function test_users_may_be_retrieved_from_cookies_with_xsrf_token_header(
$userProvider = m::mock(PassportUserProvider::class);
$tokens = m::mock(TokenRepository::class);
$clients = m::mock(ClientRepository::class);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter($key = str_repeat('a', 32), 'aes-256-cbc');

$clients->shouldReceive('findActive')
->with(1)
Expand All @@ -199,7 +199,7 @@ public function test_users_may_be_retrieved_from_cookies_with_xsrf_token_header(
'aud' => 1,
'csrf' => 'token',
'expiry' => Carbon::now()->addMinutes(10)->getTimestamp(),
], str_repeat('a', 16), 'HS256'), false)
], $key, 'HS256'), false)
);

$guard = new TokenGuard($resourceServer, $userProvider, $tokens, $clients, $encrypter, $request);
Expand All @@ -218,7 +218,7 @@ public function test_cookie_xsrf_is_verified_against_csrf_token_header()
$userProvider = m::mock(PassportUserProvider::class);
$tokens = m::mock(TokenRepository::class);
$clients = m::mock(ClientRepository::class);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter($key = str_repeat('a', 32), 'aes-256-cbc');

$request = Request::create('/');
$request->headers->set('X-CSRF-TOKEN', 'wrong_token');
Expand All @@ -228,7 +228,7 @@ public function test_cookie_xsrf_is_verified_against_csrf_token_header()
'aud' => 1,
'csrf' => 'token',
'expiry' => Carbon::now()->addMinutes(10)->getTimestamp(),
], str_repeat('a', 16), 'HS256'))
], $key, 'HS256'))
);

$guard = new TokenGuard($resourceServer, $userProvider, $tokens, $clients, $encrypter, $request);
Expand All @@ -244,7 +244,7 @@ public function test_cookie_xsrf_is_verified_against_xsrf_token_header()
$userProvider = m::mock(PassportUserProvider::class);
$tokens = m::mock(TokenRepository::class);
$clients = m::mock(ClientRepository::class);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter($key = str_repeat('a', 32), 'aes-256-cbc');

$request = Request::create('/');
$request->headers->set('X-XSRF-TOKEN', $encrypter->encrypt('wrong_token', false));
Expand All @@ -254,7 +254,7 @@ public function test_cookie_xsrf_is_verified_against_xsrf_token_header()
'aud' => 1,
'csrf' => 'token',
'expiry' => Carbon::now()->addMinutes(10)->getTimestamp(),
], str_repeat('a', 16), 'HS256'))
], $key, 'HS256'))
);

$guard = new TokenGuard($resourceServer, $userProvider, $tokens, $clients, $encrypter, $request);
Expand All @@ -274,7 +274,7 @@ public function test_users_may_be_retrieved_from_cookies_with_xsrf_token_header_
$userProvider = m::mock(PassportUserProvider::class);
$tokens = m::mock(TokenRepository::class);
$clients = m::mock(ClientRepository::class);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter(str_repeat('a', 32), 'aes-256-cbc');

$clients->shouldReceive('findActive')
->with(1)
Expand Down Expand Up @@ -315,7 +315,7 @@ public function test_users_may_be_retrieved_from_cookies_without_encryption()
$userProvider = m::mock(PassportUserProvider::class);
$tokens = m::mock(TokenRepository::class);
$clients = m::mock(ClientRepository::class);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter(str_repeat('a', 32), 'aes-256-cbc');

$clients->shouldReceive('findActive')
->with(1)
Expand Down Expand Up @@ -352,7 +352,7 @@ public function test_xsrf_token_cookie_without_a_token_header_is_not_accepted()
$userProvider = m::mock(PassportUserProvider::class);
$tokens = m::mock(TokenRepository::class);
$clients = m::mock(ClientRepository::class);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter($key = str_repeat('a', 32), 'aes-256-cbc');

$request = Request::create('/');
$request->cookies->set('XSRF-TOKEN', $encrypter->encrypt('token', false));
Expand All @@ -362,7 +362,7 @@ public function test_xsrf_token_cookie_without_a_token_header_is_not_accepted()
'aud' => 1,
'csrf' => 'token',
'expiry' => Carbon::now()->addMinutes(10)->getTimestamp(),
], str_repeat('a', 16), 'HS256'))
], $key, 'HS256'))
);

$guard = new TokenGuard($resourceServer, $userProvider, $tokens, $clients, $encrypter, $request);
Expand All @@ -378,7 +378,7 @@ public function test_expired_cookies_may_not_be_used()
$userProvider = m::mock(PassportUserProvider::class);
$tokens = m::mock(TokenRepository::class);
$clients = m::mock(ClientRepository::class);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter($key = str_repeat('a', 32), 'aes-256-cbc');

$request = Request::create('/');
$request->headers->set('X-CSRF-TOKEN', 'token');
Expand All @@ -388,7 +388,7 @@ public function test_expired_cookies_may_not_be_used()
'aud' => 1,
'csrf' => 'token',
'expiry' => Carbon::now()->subMinutes(10)->getTimestamp(),
], str_repeat('a', 16), 'HS256'))
], $key, 'HS256'))
);

$guard = new TokenGuard($resourceServer, $userProvider, $tokens, $clients, $encrypter, $request);
Expand All @@ -404,7 +404,7 @@ public function test_csrf_check_can_be_disabled()
$userProvider = m::mock(PassportUserProvider::class);
$tokens = m::mock(TokenRepository::class);
$clients = m::mock(ClientRepository::class);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter($key = str_repeat('a', 32), 'aes-256-cbc');

$clients->shouldReceive('findActive')
->with(1)
Expand All @@ -418,7 +418,7 @@ public function test_csrf_check_can_be_disabled()
'sub' => 1,
'aud' => 1,
'expiry' => Carbon::now()->addMinutes(10)->getTimestamp(),
], str_repeat('a', 16), 'HS256'), false)
], $key, 'HS256'), false)
);

$guard = new TokenGuard($resourceServer, $userProvider, $tokens, $clients, $encrypter, $request);
Expand Down Expand Up @@ -534,7 +534,7 @@ public function test_clients_may_be_retrieved_from_cookies()
$userProvider = m::mock(PassportUserProvider::class);
$tokens = m::mock(TokenRepository::class);
$clients = m::mock(ClientRepository::class);
$encrypter = new Encrypter(str_repeat('a', 16));
$encrypter = new Encrypter($key = str_repeat('a', 32), 'aes-256-cbc');

$request = Request::create('/');
$request->headers->set('X-CSRF-TOKEN', 'token');
Expand All @@ -544,7 +544,7 @@ public function test_clients_may_be_retrieved_from_cookies()
'aud' => 1,
'csrf' => 'token',
'expiry' => Carbon::now()->addMinutes(10)->getTimestamp(),
], str_repeat('a', 16), 'HS256'), false)
], $key, 'HS256'), false)
);

$guard = new TokenGuard($resourceServer, $userProvider, $tokens, $clients, $encrypter, $request);
Expand Down