Feature: add typesense remote embedding settings#934
Draft
SoongMingLiang wants to merge 1 commit into
Draft
Conversation
This PR adds the capability of customizing typesense performing remote embedding behavior through specifying parameters in config/scout.php file. Related documentation: https://typesense.org/docs/29.0/api/vector-search.html#remote-embedding-api-parameters
Member
|
I need a review from Typesense on this one. @tharropoulos |
tharropoulos
left a comment
tharropoulos
left a comment
Contributor
There was a problem hiding this comment.
These are runtime parameters on the import API, so adding them in the scout config falls in line with how we already handle the rest of the collection configuration.
They're being initialized to their defaults, so it's correct.
Contributor
Author
|
Hi @taylorotwell , just a quick nudge on this PR. Whenever you have a moment, would love to hear your feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the capability of customizing the behavior of typesense performing remote embedding through specifying parameters in config/scout.php file.
Related documentation:
https://typesense.org/docs/29.0/api/vector-search.html#remote-embedding-api-parameters