feat(scout): fix queue configuration options#938
Closed
faraweilyas wants to merge 3 commits into
Closed
Conversation
- Change queue config from boolean to nested array structure - Add configurable queue connection and queue name options - Update comment to reflect new configuration format - Maintain backward compatibility through environment variables This allows for more granular control over Scout's queueing behavior while keeping the same simple enable/disable functionality.
Member
|
Seems like a breaking change with the way this is implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Scout queue configuration options
Description
This PR fixes Laravel Scout's queue configuration by expanding from a simple boolean flag to a nested array structure, allowing developers to specify custom queue connections and queue names while maintaining full backward compatibility.
Checkout the queue doc section to spot the bug.
Changes Made
'queue' => booleanto nested array withenable,connection, andqueueoptionsmakeSearchable()andremoveFromSearch()methods to useconfig()->boolean('scout.queue.enable')instead ofconfig('scout.queue')SCOUT_QUEUE_CONNECTIONandSCOUT_QUEUE_NAMEfor easier configuration managementSCOUT_QUEUE=true/falsecontinues to work as expectedBenefits to End Users
config()->boolean()provides clearer intent and better type safetyCode Changes
config file updates:
Searchable trait updates: