Fix namespaces for PHP 8.4 #112
Merged
+177
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReflectionFunction::getNamespaceName() no longer returns a meaningful namespace for closures starting with PHP 8.4.
Especially for resolving relative namespaces in PHP 8.4.
The only case not handled is to ignore 'use' statements that appear after usage within the same namespace.
|
The only situation not handled is when using a name before the Finally, I left |
The unused 'use' statements are essential for the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes relative namespaces handling for PHP 8.4, which has an unfortunate breaking change about how
ReflectionFunction::getNamespaceName()works for closures.It also fixes namespace resolution in files with multiple namespaces, where only the
usestatements in the current namespace must be considered.Fixes #111