Integration artisan make commands with VSCode explorer/context#466
Conversation
…ration-artisan-make-commands-with-VSCode-explorercontext-#61
|
Hey @N1ebieski, after my DDEV PR, I felt much more comfortable working on this extension and dedicating more time to it. I see you have a couple open PRs, and you mentioned above that you need more feedback especially on macOS, so I'm just gonna take some time and review your PRs on my mac so @joetannenbaum spends a little bit less time on them, cause you got lot of 'em PRs haha. Super nice work you doing and thank you man! |
damms005
left a comment
There was a problem hiding this comment.
Excellent work by @N1ebieski thank you! I've tested this on my mac and works perfectly. I make a few comments so you may want to look at those.
@joetannenbaum this PR adds significant amount of context menu entries. If we are going this direction then perhaps it's time we have a new dedicated main Laravel menu entry and we should shove all commands in there as sub-entry, including the recently merged wrappers
|
@damms005 Thanks for your review! |
…ration-artisan-make-commands-with-VSCode-explorercontext-#61
|
Hey @N1ebieski! Thanks so much for putting this together. This is a really solid addition to the extension and something I think people will definitely find useful. I’m keen to dive into the review, but it looks like there are quite a few extra changes in here from other PRs that aren't related to the main feature. To make things a bit easier to track and merge, could you please clean up the branch and leave just the logic for the Artisan make command? Once those unrelated bits are out of the way, I'll be happy to give it a final look! |
|
Hi @TitasGailius, Hmm… this PR only contains #469, which is required for this PR to work on Windows. Are you sure I should remove it? |
|
@N1ebieski, thanks for clarifying. Let's leave it for now. I'll take a close look at this PR soon. |
|
@N1ebieski thanks a lot! I love it. This is a very cool feature and I am sure a lot of developers will love it too. 🙌 |
|
Is there a way to disable this feature so I don't see it in the file browser context menu? :) |
|
@Junveloper Sorry, I forgot about that. I've prepared the fix: #530 |
|
@N1ebieski You are awesome, thank you! Can't wait for that to be merged :) |
This PR is a sort of GUI for Laravel Artisan Make commands. Almost every Laravel class type is integrated with VSCode
explorer/contextmenu. For example, when the user right-clicks on the folder in Controllers folder, he can choose the "New Controller…" option. Similarly, right-clicking on the folder in Observers shows the "New Observer…" option and so on. Some examples:php artisan stub:publishand modify them for his own purposes.I tested the feature mainly under Linux in WSL, with a few successful tests on native Windows. I can't test every option (especially under macOS), so feedback is needed.
Contains #469