Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace headlessui transition with vue built-in #76

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

laserhybiz
Copy link
Contributor

@laserhybiz laserhybiz commented Mar 6, 2025

Vue has built in transition components, no need to have a package for this. (the package is for more complex transitions, i.e. nested child transitions from a single root component)

Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @laserhybiz,

Less dependencies the better, it looks great. Could you submit this update in the React starter kit as well?

@tnylea tnylea added the Approved Approved for merge label Mar 7, 2025
@laserhybiz
Copy link
Contributor Author

@tnylea I'm not really familiar with react, not sure if they have built in transition

@laserhybiz
Copy link
Contributor Author

@tnylea What I can do is replace the component with just css transitions (but it will use opacity instead of v-show)

<p
    class="text-sm text-neutral-600 transition-opacity duration-300 ease-in-out opacity-0"
    :class="{ 'opacity-100': form.recentlySuccessful }"
>
    Saved.
</p>

@taylorotwell taylorotwell merged commit bb6a736 into laravel:main Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants